Re: Too-short timeouts in test code

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Too-short timeouts in test code
Date: 2018-12-09 03:26:54
Message-ID: 20181209032654.GE1833@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 08, 2018 at 06:24:35PM -0800, Noah Misch wrote:
> pg_recvlogical_upto() has the ability to make timeout non-fatal, by calling it
> in an array context. No in-tree test uses that. Out-of-tree code using that
> feature would likely benefit from the ability to set timeout duration. Hence,
> I'm inclined not remove the timeout duration parameter.

No objections with this line of thoughts. The rest of the patch looks
fine to me.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-12-09 07:44:57 Re: [Todo item] Add entry creation timestamp column to pg_stat_replication
Previous Message Noah Misch 2018-12-09 02:24:35 Re: Too-short timeouts in test code