Re: [HACKERS] Bug when dumping "empty" operator classes

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: [HACKERS] Bug when dumping "empty" operator classes
Date: 2018-12-08 01:11:42
Message-ID: 20181208011142.GU3415@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
> On Fri, May 26, 2017 at 8:14 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >> On 26 May 2017, at 17:08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> I'll commit and back-patch this without a test case. Possibly Frost will
> >> be excited enough about it to add something to the pg_dump TAP tests,
> >> but those tests are too opaque for me to want to do so.
>
> For the TAP tests I think that you are looking for something like the
> attached. Stephen, perhaps you could consider including this test in
> the suite?

Another blast from the past. I've updated this to the new pg_dump
test-suite system but otherwise it's basically the same test.

Barring concerns, I'll plan to push this later this weekend.

Thanks!

Stephen

Attachment Content-Type Size
add-empty-op-class-pg_dump-test-v1_master.patch text/x-diff 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2018-12-08 01:45:32 extended query protcol violation?
Previous Message Alexander Korotkov 2018-12-08 00:25:11 Re: Statement-level rollback