Re: don't create storage when unnecessary

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: don't create storage when unnecessary
Date: 2018-12-06 22:51:15
Message-ID: 20181206225115.cyp53konqyxgerly@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-12-06 18:55:52 -0300, Alvaro Herrera wrote:
> Some time ago, after partitioned indexes had been pushed, I realized
> that even though I didn't want them to have relfilenodes, they did. And
> looking closer I noticed that *a lot* of relation kinds that didn't need
> relfilenodes, had them anyway.
>
> This patch fixes that; if no relfilenode is needed, it's not created.
>
> I didn't verify pg_upgrade behavior across this commit. Maybe something
> needs tweaking there.

Hm, that generally sounds like a good plan. Could we back this up with
tests in misc_sanity.sql or such?

- Andres

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-12-06 22:51:24 Re: Hint and detail punctuation
Previous Message Elvis Pranskevichus 2018-12-06 22:27:32 [PATCH] Allow anonymous rowtypes in function return column definition