| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "myungkyu(dot)lim" <myungkyu(dot)lim(at)samsung(dot)com> |
| Cc: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com>, 'PostgreSQL-development' <pgsql-hackers(at)postgresql(dot)org>, woosung(dot)sohn(at)samsung(dot)com, don(dot)hong(at)samsung(dot)com |
| Subject: | Re: [Todo item] Add entry creation timestamp column to pg_stat_replication |
| Date: | 2018-11-30 08:54:15 |
| Message-ID: | 20181130085415.GI2267@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 29, 2018 at 05:43:26PM +0900, myungkyu.lim wrote:
> Changed field name 'last_msg_send_time' to 'reply_time'.
Looks pretty to me at quick glance, unfortunately I have not spent much
time on it, particularly testing it.
+ <row>
+ <entry><structfield>reply_time</structfield></entry>
+ <entry><type>timestamp with time zone</type></entry>
+ <entry>Send time of last message received from WAL
receiver</entry>
+ </row>
This is a bit confusing as this counts for the last *standby* message
('r'), and not the last feedback message ('h').
+ /*
+ * timestamp of the latest message, reported by standby server
+ */
+ TimestampTz replyTime;
A small indentation problem, not a big deal.
Sawada-san, perhaps you would like to look at it?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2018-11-30 09:40:09 | Re: Changing the autovacuum launcher scheduling; oldest table first algorithm |
| Previous Message | Adrien NAYRAT | 2018-11-30 08:51:58 | Re: New GUC to sample log queries |