Re: Fixes for missing schema qualifications

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fixes for missing schema qualifications
Date: 2018-11-30 08:18:09
Message-ID: 20181130081809.GG2267@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Thu, Nov 29, 2018 at 10:29:04PM -0800, Noah Misch wrote:
> This patch provides no meaningful increment in security or reliability, but it
> does improve stylistic consistency. Fine to proceed on those grounds, but
> this description doesn't fit.

Indeed, you are right. I agree.

> > --- a/src/test/modules/worker_spi/worker_spi.c
> > +++ b/src/test/modules/worker_spi/worker_spi.c
> > @@ -115,7 +115,9 @@ initialize_worker_spi(worktable *table)
> >
> > /* XXX could we use CREATE SCHEMA IF NOT EXISTS? */
> > initStringInfo(&buf);
> > - appendStringInfo(&buf, "select count(*) from pg_namespace where nspname = '%s'",
> > + appendStringInfo(&buf,
> > + "select pg_catalog.count(*) "
> > + "from pg_catalog.pg_namespace where nspname = '%s'",
> > table->schema);
>
> Remove this change. The rest of the file doesn't schema-qualify, which is
> appropriate for code implementing a test case.

No problem with that either. Thanks Noah for the lookup.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-11-30 08:26:27 Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)
Previous Message David Rowley 2018-11-30 07:25:30 Re: Planning time of Generic plan for a table partitioned into a lot