Re: [PATCH] Change "checkpoint starting" message to use "wal"

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: 'Christoph Berg' <christoph(dot)berg(at)credativ(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Change "checkpoint starting" message to use "wal"
Date: 2018-11-30 00:31:02
Message-ID: 20181130003102.GU3415@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Tsunakawa, Takayuki (tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com) wrote:
> From: Christoph Berg [mailto:christoph(dot)berg(at)credativ(dot)de]
> > A customer was complaining that the "checkpoint starting: xlog"
> > message was not included in the grand PG10 rename of user-visible bits.
> > The attached patch fixes that.
>
> Can we make use of this chance to change elog() to ereport(), so that the two messages are translated?

+1, and we should probably look for nearby cases to fix also..

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2018-11-30 01:02:51 Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager
Previous Message Tsunakawa, Takayuki 2018-11-30 00:28:23 RE: [PATCH] Change "checkpoint starting" message to use "wal"