| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, David Steele <david(at)pgmasters(dot)net>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, andrew(at)dunslane(dot)net, daniel(at)yesql(dot)se, magnus(at)hagander(dot)net, tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Subject: | Re: More issues with pg_verify_checksums and checksum verification in base backups |
| Date: | 2018-11-27 22:45:41 |
| Message-ID: | 20181127224541.GK3415@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
* Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> On Mon, Nov 19, 2018 at 10:17:19PM -0500, Stephen Frost wrote:
> > Let's try to not conflate these two issues though, they're quite
> > independent.
>
> This is a poke about a recent issue raised by Michael Banck here:
> https://www.postgresql.org/message-id/f1543332405.17247.9.camel@credativ.de
> And for which I am suggesting a minimal fix, which is extracted from a
> patch at the most-top of this thread:
> https://www.postgresql.org/message-id/20181127213625.GM1716@paquier.xyz
>
> If there are no objections, I would like to fix the actual issue. Then
> I'll rebase a patch on top of what has been fixed for this thread for
> what I proposed in the base backup code.
So the as-committed "whitelist" approach did, in fact, end up excluding
huge portions of the database from being checked, that is, everything
inside of tablespaces.
This doesn't exactly change my opinion regarding this discussion and I'd
rather we revert the "whitelist" patch and use the very minimal patch
from here:
https://www.postgresql.org/message-id/20181012013918.GA30064%40paquier.xyz
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-11-27 22:59:34 | Re: Handling of REGRESS_OPTS in MSVC for regression tests |
| Previous Message | Stephen Frost | 2018-11-27 22:20:17 | Re: Remove Deprecated Exclusive Backup Mode |