Re: pgsql: Add TAP tests for pg_verify_checksums

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Michael Banck <michael(dot)banck(at)credativ(dot)de>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add TAP tests for pg_verify_checksums
Date: 2018-11-27 13:52:21
Message-ID: 20181127135221.GG1716@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Nov 27, 2018 at 02:09:05PM +0100, Michael Banck wrote:
> I had a quick look at fixing this but did not manage to immediately come
> up with a solution, so posting here for now.

If you look at another thread, the patch posted on the top would
actually solve this issue:
https://www.postgresql.org/message-id/20181021134206.GA14282@paquier.xyz

Your problem could also be solved with the minimalistic patch attached,
so fixing on the way the problems with temporary files present in PGDATA
something like the attached could be used... Based on the stale status
of the other thread I am unsure what should be done though.
--
Michael

Attachment Content-Type Size
verify-checksum-tablespace.patch text/x-diff 5.8 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Sergei Kornilov 2018-11-27 14:16:20 Re: pgsql: Integrate recovery.conf into postgresql.conf
Previous Message Michael Banck 2018-11-27 13:09:05 Re: pgsql: Add TAP tests for pg_verify_checksums

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-27 13:55:24 Re: Remove Deprecated Exclusive Backup Mode
Previous Message Peter Eisentraut 2018-11-27 13:25:20 Re: SSL tests failing with "ee key too small" error on Debian SID