| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | bossartn(at)amazon(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Use durable_unlink for .ready and .done files for WAL segment removal |
| Date: | 2018-11-27 12:34:40 |
| Message-ID: | 20181127123440.GF1716@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 22, 2018 at 01:16:09PM +0900, Michael Paquier wrote:
> No, pgarch_readyXLog() should still look after .ready files as those are
> here for this purpose, but we could have an additional check to see if
> the segment linked with it actually exists and can be archived. This
> check could happen in pgarch.c code before calling the archive command
> gets called (just before pgarch_ArchiverCopyLoop and after
> XLogArchiveCommandSet feels rather right, and that it should be cheap
> enough to call stat()).
s/pgarch_ArchiverCopyLoop/pgarch_archiveXlog/.
Attached is a patch showing shaped based on the idea of upthread.
Thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| archive-missing-v2.patch | text/x-diff | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-11-27 12:45:20 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| Previous Message | Peter Eisentraut | 2018-11-27 12:29:27 | Re: pgsql: Integrate recovery.conf into postgresql.conf |