Re: pgsql: Integrate recovery.conf into postgresql.conf

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Integrate recovery.conf into postgresql.conf
Date: 2018-11-26 00:28:49
Message-ID: 20181126002849.GD1776@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, Nov 25, 2018 at 03:49:23PM +0000, Peter Eisentraut wrote:
> Integrate recovery.conf into postgresql.conf
>
> recovery.conf settings are now set in postgresql.conf (or other GUC
> sources). Currently, all the affected settings are PGC_POSTMASTER;
> this could be refined in the future case by case.

The buildfarm is unhappy after this one:
https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=culicidae&br=HEAD

If I use -DEXEC_BACKEND when compiling the tests complain about a
timeout in 003_recovery_targets. Here is what the buildfarm reports, I
can see the failure by myself as well:
# Postmaster PID for node "standby_6" is 26668
# poll_query_until timed out executing this query:
# SELECT '0/3022690'::pg_lsn <= pg_last_wal_replay_lsn()
# expecting this output:
# t
# last actual query output:
# f
# with stderr:
Timed out while waiting for standby to catch up at
t/003_recovery_targets.pl line 34.

Peter, could you look at that?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-11-26 00:33:51 Re: pgsql: Add PGXS options to control TAP and isolation tests
Previous Message Michael Paquier 2018-11-25 23:59:40 Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2018-11-26 00:29:54 Re: Copy function for logical replication slots
Previous Message Thomas Munro 2018-11-26 00:17:24 Re: SSL tests failing with "ee key too small" error on Debian SID