Re: [RFC] Removing "magic" oids

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [RFC] Removing "magic" oids
Date: 2018-11-21 00:07:59
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2018-11-20 01:52:27 -0800, Andres Freund wrote:
> I'm pretty happy with the new state. Unless somebody announces they want
> to do a review soon-ish, I'm planning to commit this soon. It's a
> painful set to keep up2date, and it's blocking a few other patches. I'm
> sure we'll find some things to adapt around the margins, but imo the
> patch as a whole looks pretty reasonable.
> Missing:
> - nice and long commit message
> - another detailed line-by-line read of the patch (last round took like
> 3h :()
> 341 files changed, 2263 insertions(+), 4249 deletions(-)

I've now pushed this. There's one bugfix (forgot to unset replaces for
the oid column in heap_modify_tuple), and one mostly cosmetic change:
Previously the .bki insert lines had the oid duplicated between OID =
and the normal column, now it's just the latter.

Let's see what I broke :/



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-21 00:39:53 Re: Add extension options to control TAP and isolation tests
Previous Message Andres Freund 2018-11-21 00:07:58 pgsql: Remove WITH OIDS support, change oid catalog column visibility.