Re: Psql patch to show access methods info

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: s(dot)cherkashin(at)postgrespro(dot)ru
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Psql patch to show access methods info
Date: 2018-11-20 13:42:41
Message-ID: 20181120134241.36tjfswliqimvncv@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2018-Nov-20, s(dot)cherkashin(at)postgrespro(dot)ru wrote:

> Ok, I fixed this.

Cool. I'm not sure this is a good idea: "c.relname::pg_catalog.regclass"
I would use c.oid::pg_catalog.regclass instead.

But before getting into those details, I think we should discuss the
user interface that this patch is offering:

\dip [am pattern]
lists index properties (according to doc patch)
* OK, but why do we need an AM pattern? ... reads regress output ...
oh, actually it's an index name pattern, not an AM pattern. Please fix docs.

\dicp [idx pattern] [column pattern]
list index column properties
* I think the column pattern part is pointless.

Please explain what these are.

I think this is two patches -- one being the \dip/\dicp part, the other
the \dA additions. Let's deal with them separately?

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message 066ce286 2018-11-20 14:06:28 Re: mysql_fdw crash
Previous Message Fabien COELHO 2018-11-20 13:41:04 Re: pgbench - doCustom cleanup