| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: heap_sync seems rather oblivious to partitioned tables (wal_level=minimal) |
| Date: | 2018-11-19 14:19:07 |
| Message-ID: | 20181119141907.jfoa76ikca7hzg56@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Nov-19, Tomas Vondra wrote:
> On 11/17/18 4:53 PM, Alvaro Herrera wrote:
> > Here are versions for branches 10 and 11. The main change is that the
> > COPY test didn't have the partitioned table, because it was recently
> > introduced (0d5f05cde011) so I backpatched that part also. It's a bit
> > useless, but I'd rather backpatch the same thing rather than have
> > different lines there ...
>
> The patch seems fine to me.
Pushed now, thanks.
> It's a bit unfortunate that we simply disable the optimization on
> partitioned tables instead of fixing it somehow, but I guess it's better
> than nothing and no one has a very good idea how to make it work.
Yeah, I think leaving it in the current state is worse than disabling
it, since an error is thrown anyway. In any case, I guess when we have
a patch it won't be backpatchable.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adelino Silva | 2018-11-19 14:54:13 | |
| Previous Message | Dmitry Dolgov | 2018-11-19 13:52:05 | Re: New GUC to sample log queries |