| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: _isnan() on Windows |
| Date: | 2018-11-17 19:46:06 |
| Message-ID: | 20181117194606.5mt3ru4nmaoa5op4@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-07-12 11:28:46 -0400, Andrew Dunstan wrote:
> On 07/12/2018 10:38 AM, Tom Lane wrote:
> > Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> > > On 07/12/2018 10:20 AM, Tom Lane wrote:
> > > > bowerbird and hamerkop have some gripes like this:
> > > >
> > > > bowerbird | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition (src/pl/plperl/SPI.c) [G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
> > > We actually undef a bunch of things in plperl.h to keep the compiler
> > > quiet. Maybe we need to add this to the list?
> > Perhaps. But how do we tell the platforms where we should do that
> > from the ones where we shouldn't?
> >
> >
>
> In the _MSCVER section:
>
> #ifdef isnan
> #undef isnan
> #endif
>
> By inspection the perl header is just defining it to _isnan, for every MSC
> version.
Let's try undefining it before plperl.h then? It'd be nice to get rid
of those warnings...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-17 20:22:20 | Re: BUG #15160: planner overestimates number of rows in join when there are more than 200 rows coming from CTE |
| Previous Message | Tom Lane | 2018-11-17 19:32:03 | Re: Now/current_date and proleakproof |