| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: fix psql \conninfo & \connect when using hostaddr |
| Date: | 2018-11-17 12:55:27 |
| Message-ID: | 20181117125527.aq4ezesjgszuz6vj@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Nov-17, Alvaro Herrera wrote:
> Looks good to me, save that I would change the API of getHostaddr() to
> this:
>
> /* ----------
> * getHostaddr -
> * Fills 'host_addr' with the string representation of the currently connected
> * socket in 'conn'.
> * ----------
> */
> static void
> getHostaddr(PGconn *conn, char *host_addr, int host_addr_len)
Fabien, are you planning to fix things per Arthur's review?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2018-11-17 13:18:01 | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
| Previous Message | Alvaro Herrera | 2018-11-17 12:50:42 | Re: fix psql \conninfo & \connect when using hostaddr |