| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: ATTACH/DETACH PARTITION CONCURRENTLY |
| Date: | 2018-11-16 04:00:23 |
| Message-ID: | 20181116040023.GD6613@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 16, 2018 at 10:57:57AM +0900, Amit Langote wrote:
> Maybe partition_bounds_create() should've had a MemoryContext argument to
> pass it the context we want it to create the PartitionBoundInfo in. That
> way, we can simply pass rd_pdcxt to it and avoid making a copy. As is,
> we're now allocating two copies of PartitionBoundInfo, one in the
> CurrentMemoryContext and another in rd_pdcxt, whereas the previous code
> would only allocate the latter. Maybe we should fix it as being a regression.
Not sure about what you mean by regression here, but passing the memory
context as an argument has sense as you can remove the extra partition
bound copy, as it has sense to use an array instead of a list for
performance, which may matter if many partitions are handled when
building the cache. So cleaning up both things at the same time would
be nice.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2018-11-16 04:13:44 | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
| Previous Message | Amit Kapila | 2018-11-16 03:00:00 | Re: WIP: Avoid creation of the free space map for small tables |