| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Speeding up INSERTs and UPDATEs to partitioned tables |
| Date: | 2018-11-14 23:58:42 |
| Message-ID: | 20181114235842.5knil7dbs23cegiz@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Nov-15, David Rowley wrote:
> On 15 November 2018 at 07:10, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > What's with this comment?
> >
> > * Initially we must only set up 1 PartitionDispatch object; the one for
> > * the partitioned table that's the target of the command. If we must
> > * route a tuple via some sub-partitioned table, then its
> > * PartitionDispatch is only built the first time it's required.
> >
> > You're setting the allocsize to PARTITION_ROUTING_INITSIZE, which is at
> > odds with the '1' mentioned in the comment. Which is wrong?
>
> I don't think either is wrong, but I guess something must be
> misleading, so could perhaps be improved.
Ah, that makes sense. Yeah, it seems a bit misleading to me. No
worries.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-15 00:03:32 | Re: doc - improve description of default privileges |
| Previous Message | Tom Lane | 2018-11-14 23:02:53 | Re: Constraint documentation |