Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well

From: Andres Freund <andres(at)anarazel(dot)de>
To: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date: 2018-11-13 21:57:16
Message-ID: 20181113215716.qsdhsg54dmg6kvdl@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-11-13 11:40:05 +0100, Christoph Berg wrote:
> While working on making extension modules built reproducibly, I
> noticed that extra flags passed via COPT (notably -ffile-prefix-map)
> do not get added to CXXFLAGS.

PROFILE I can see, but COPT I'm less sure. The name suggests it's about
C not C++. How about adding CXXOPT?

Secondary question: Why aren't you using CFLAGS/CXXFLAGS for this?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jordan Deitch 2018-11-13 22:02:48 add the source of param misconfigurations to error messages
Previous Message Peter Geoghegan 2018-11-13 21:29:25 Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)