|From:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|To:||Michael Paquier <michael(at)paquier(dot)xyz>|
|Cc:||Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: move PartitionBoundInfo creation code|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2018-Nov-13, Michael Paquier wrote:
> On Tue, Nov 13, 2018 at 09:58:08AM -0300, Alvaro Herrera wrote:
> > "the context that was active when the function was called" is typically
> > expressed simply as "the current memory context". Perhaps the whole
> > phrase can be reduced to "The object returned by this function is wholly
> > allocated in the current memory context"?
> Yes, that looks cleaner. I am planning to do a last lookup round on
> tomorrow morning my time before committing, so I may still tweak a
> couple of other words...
I gave the patch a read and it looks reasonable to me.
Memory management in RelationBuildPartitionDesc is crummy, but I don't
think it's this patch's fault.
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Sergei Kornilov||2018-11-13 14:57:10||Re: Continue work on changes to recovery.conf API|
|Previous Message||Jeremy Finzel||2018-11-13 13:57:38||Re: Race condition in WaitForBackgroundWorkerStartup|