Re: Removal of unnecessary CommandCounterIncrement() when doing ON COMMIT DELETE ROWS

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Removal of unnecessary CommandCounterIncrement() when doing ON COMMIT DELETE ROWS
Date: 2018-11-12 16:19:31
Message-ID: 20181112161931.x6w7vcczs2o64kmw@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Nov-09, Michael Paquier wrote:

> Hi all,
>
> When doing a set of ON COMMIT DELETE ROWS actions for relations, there
> is a CCI happening after each truncation:

Right, but note that this is not a loop so it's only one CCI, not one
per relation. (This doesn't seem a big deal either way, but I see no
reason to have that line there.)

> And I think that I agree with that, because visibly this applies to
> index rebuilds but in those cases CCIs are happening locally. So I
> think that we can get rid of that, and I suggest to remove it only on
> HEAD only of course.

+1

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-11-12 16:21:10 Re: Uninterruptible long planning of a query with too many WHERE clauses
Previous Message John Naylor 2018-11-12 14:42:45 Re: doc fix for pg_stat_activity.backend_type