Re: shared-memory based stats collector

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: tomas(dot)vondra(at)2ndquadrant(dot)com
Cc: alvherre(at)2ndquadrant(dot)com, andres(at)anarazel(dot)de, ah(at)cybertec(dot)at, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: shared-memory based stats collector
Date: 2018-11-12 11:10:42
Message-ID: 20181112.201042.147595779.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

At Fri, 9 Nov 2018 14:16:31 +0100, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote in <803f2d96-3b4b-f357-9a2e-45443212f13d(at)2ndquadrant(dot)com>
>
>
> On 11/9/18 9:33 AM, Kyotaro HORIGUCHI wrote:
> > Hello. This is rebased version.
> > At Thu, 8 Nov 2018 16:06:49 +0100, Tomas Vondra
> > <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote in
> > <de249c3f-79c9-b75c-79a3-5e2d008548a8(at)2ndquadrant(dot)com>
> >> However a quite a few extensions in contrib seem are broken now. It
> >> seems fixing it is as simple as including the new bestatus.h next to
> >> pgstat.h.
> > The additional 0009 does that.
> >
>
> That does fix it, indeed. But the break happens in 0003, so that's
> where the fixes should be moved - I've tried to simply apply 0009
> right after 0003, but that does not seem to work because bestatus.h
> does not exist at that point yet :-/

Sorry, I misunderstood you. The real reason for breaking 0003 as
you saw was the result I just removed PG_STAT_TMP_DIR. 0005 fixes
that later. I (half-intentionally) didin't keep soundness of the
source tree at v8-0003 and v8-0008.

> The current split into 8 parts seems quite sensible to me, i.e. that's
> how it might get committed eventually. That however means each part
> needs to be correct on it's own (hence fixes in 0009 are a problem).

Thanks. I neatended up the patchset so that individual patch
keeps source buildable and doesn't break programs' behaviors.

v9-0001-sequential-scan-for-dshash.patch
v9-0002-Add-conditional-lock-feature-to-dshash.patch
same to v8

v9-0003-Make-archiver-process-an-auxiliary-process.patch
moved from v8-0004 since this is applicable independently from
v8-0003.

v9-0004-Shared-memory-based-stats-collector.patch
v8-0003 + some fixes to make contribs work and removed initdb
part.

v9-0005-Remove-statistics-temporary-directory.patch
v8-0005 + v8-0006 + initdb part of v8-0003. pg_stat_statements
may still need fix since I changed only the directory for
temporary query files.

v9-0006-Split-out-backend-status-monitor-part-from-pgstat.patch
v8-0008 plus v8-0009

v9-0007-Documentation-update.patch
this still leaves description about UDP-based stats collector
and will need further edit.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v9-0007-Documentation-update.patch text/x-patch 6.1 KB
v9-0006-Split-out-backend-status-monitor-part-from-pgstat.patch text/x-patch 174.6 KB
v9-0005-Remove-statistics-temporary-directory.patch text/x-patch 7.4 KB
v9-0004-Shared-memory-based-stats-collector.patch text/x-patch 208.4 KB
v9-0003-Make-archiver-process-an-auxiliary-process.patch text/x-patch 12.0 KB
v9-0002-Add-conditional-lock-feature-to-dshash.patch text/x-patch 4.1 KB
v9-0001-sequential-scan-for-dshash.patch text/x-patch 10.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2018-11-12 11:41:40 Re: BUG #15449: file_fdw using program cause exit code error when using LIMIT
Previous Message Thomas Munro 2018-11-12 10:11:19 Re: DSM segment handle generation in background workers