| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Subject: | Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation |
| Date: | 2018-11-08 15:51:54 |
| Message-ID: | 20181108155154.jq623btpai6ufbw3@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2018-Nov-07, Amit Langote wrote:
> I think the result in this case should be an error, just as it would in
> the regular inheritance case.
>
> create table parent (a text);
> create table child (a text collate "en_US") inherits (parent);
> NOTICE: merging column "a" with inherited definition
> ERROR: column "a" has a collation conflict
> DETAIL: "default" versus "en_US"
>
> In fact, I see that ATTACH PARTITION rejects a partition if collations
> don't match.
Hmm, I'm thinking perhaps we shouldn't backpatch this part. It's
obviously a bug, but we might break somebody's working apps. Therefore
I think I'd rather leave it out of the current bugfix and commit
separately.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kanwei Li | 2018-11-08 16:29:35 | Re: BUG #15489: Segfault on DELETE |
| Previous Message | Tom Lane | 2018-11-08 14:48:11 | Re: BUG #15493: Wrong name of fields/missing fields for the internal statistic |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-08 15:56:33 | Re: Disallow setting client_min_messages > ERROR? |
| Previous Message | Alvaro Herrera | 2018-11-08 15:39:41 | Re: shared-memory based stats collector |