| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix copy-paste error in errhint() introduced in 691d79a07933. |
| Date: | 2018-11-07 22:08:33 |
| Message-ID: | 20181107220833.w5rcqqa7mnlz6hoa@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi,
On 2018-11-07 22:32:22 +0100, Christoph Berg wrote:
> Re: Andres Freund 2018-11-05 <E1gJlBt-0005mL-45(at)gemulon(dot)postgresql(dot)org>
> > Fix copy-paste error in errhint() introduced in 691d79a07933.
> >
> > Reported-By: Petr Jelinek
> > Discussion: https://postgr.es/m/c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com
> > Backpatch: 9.4-, like the previous commit
>
> - errhint("Change wal_level to be replica or higher.")));
> + errhint("Change wal_level to be logical or higher.")));
>
> Are there wal_levels higher than logical?
Not right now, but it seems quite likely that there will be. IIRC we've
phrased a few other messages like that. It's quite likely that otherwise
the message would be forgotten to be updated. And it's not like it's
incorrect.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-11-07 22:15:10 | Re: pgsql: Move EEOP_*_SYSVAR evaluation out of line. |
| Previous Message | Andres Freund | 2018-11-07 22:03:39 | pgsql: Fixup for b84a6dafbf triggering assert failure in LLVM debug bui |