Re: pgbench -M option can be specified more than once

Hi,

On 2018-11-03 10:12:14 +0900, Tatsuo Ishii wrote:
> > Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> writes:
> >> While playing with pgbench, I found multiple "-M query_mode" can be
> >> set more than once. For example,
> >
> > I think that's true of just about every option in all of our programs.
> > Why is this one instance so much worse than others that it deserves
> > to be handled differently?
>
> One of my colleagues actually believed that if both "-M extended" and
> "-M prepared" were specified, pgbench runs in mixture of those
> modes. So I felt avoiding such misunderstanding is more important.

I regularly specify options multiple times, and I'd hate for that to not
work anymore. It's really useful to set defaults for scripts that then
can be overwritten by the caller by passing on "$@" (i.e. all script
arguments).

Greetings,

Andres Freund