Re: replication_slots usability issue

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: replication_slots usability issue
Date: 2018-11-01 00:34:05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

HI Andres,

On Wed, Oct 31, 2018 at 03:48:02PM -0700, Andres Freund wrote:
> And done. Thanks for the report JD.

Shouldn't we also switch the PANIC to a FATAL in RestoreSlotFromDisk()?
I don't mind doing so myself if you agree with the change, only on
HEAD as you seemed to disagree about changing that on back-branches.

Also, from 691d79a which you just committed:
+ ereport(FATAL,
+ errmsg("logical replication slots \"%s\" exists, but wal_level < logical",
+ NameStr(,
I can see one grammar mistake here, as you refer to only one slot here.
The error messages should read:
"logical replication slot \"%s\" exists, but wal_level < logical"
"physical replication slot \"%s\" exists, but wal_level < replica"


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-11-01 00:35:30 Re: Speeding up INSERTs and UPDATEs to partitioned tables
Previous Message Andreas 'ads' Scherbaum 2018-11-01 00:32:09 Re: INSTALL file