| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Bruno Wolff III <bruno(at)wolff(dot)to>, pgsql-general(at)lists(dot)postgresql(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Should pg 11 use a lot more memory building an spgist index? |
| Date: | 2018-10-26 14:09:27 |
| Message-ID: | 20181026140927.oh4gd367st47li6h@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On 2018-Oct-26, Tom Lane wrote:
> After a quick look around, I think that making systable_begin/endscan
> do this is a nonstarter; there are just too many call sites that would
> be affected. Now, you could imagine specifying that indexes on system
> catalogs (in practice, only btree) have to clean up at endscan time
> but other index types don't, so that only operations that might be
> scanning user indexes need to have suitable wrapping contexts. Not sure
> there's a lot of benefit to that, though.
How about modifying SysScanDescData to have a memory context member,
which is created by systable_beginscan and destroyed by endscan?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-10-26 14:20:02 | Re: Should pg 11 use a lot more memory building an spgist index? |
| Previous Message | Adrian Klaver | 2018-10-26 13:42:44 | Re: ERROR: type "myrowtype" does not exist |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-10-26 14:13:20 | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER |
| Previous Message | Fabien COELHO | 2018-10-26 13:54:51 | fix psql \conninfo & \connect when using hostaddr |