| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot |
| Date: | 2018-10-22 15:36:25 |
| Message-ID: | 20181022153625.d5r7yui5qoway66u@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-Oct-14, Andres Freund wrote:
> On 2018-10-14 13:26:24 +0000, Michael Paquier wrote:
> > Avoid duplicate XIDs at recovery when building initial snapshot
> I'm unhappy this approach was taken over objections. Without a real
> warning. Even leaving the crummyness aside, did you check other users
> of XLOG_RUNNING_XACTS, e.g. logical decoding?
Mumble. Is there a real problem here -- I mean, did this break logical
decoding? Maybe we need some more tests to ensure this stuff works
sanely for logical decoding.
FWIW and not directly related, I recently became aware (because of a
customer question) that txid_current_snapshot() is oblivious of
XLOG_RUNNING_XACTS in a standby. AFAICS it's not a really serious
concern, but it was surprising.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-10-22 17:41:55 | Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot |
| Previous Message | Michael Paquier | 2018-10-22 06:40:53 | Re: pgsql: Set pg_class.relhassubclass for partitioned indexes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-10-22 15:45:28 | Re: relhassubclass and partitioned indexes |
| Previous Message | Jeremy Finzel | 2018-10-22 14:36:07 | Changes to error handling for background worker initialization? |