| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Date: | 2018-10-20 05:16:05 |
| Message-ID: | 20181020051605.pnemvsfmawdpiufe@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2018-10-20 00:25:19 -0400, Stephen Frost wrote:
> If we are going to decide that we only deal with files in our directories
> matching these whitelisted patterns, then shouldn’t we apply similar logic
> in things like DROP DATABASE and any other cases where we perform actions
> in a recursive manner across our database and table space directories?
I'm honestly not sure if you're just trolling at this point. Why would
anybody reasonable be concerned about DROP DATABASE dropping the
directory for the database? You're not honestly suggesting that anybody
would write an extension or anything like that that stores data in the
wrong database's directory, right? Other iterations like fsyncing
files, copying the entire template database directory, etc are similarly
harmless or positive.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-10-20 05:53:38 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Previous Message | Andres Freund | 2018-10-20 05:11:48 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-10-20 05:45:23 | Re: Multi-insert into a partitioned table with before insert row trigger causes server crash on latest HEAD |
| Previous Message | Andres Freund | 2018-10-20 05:11:48 | Re: pgsql: Add TAP tests for pg_verify_checksums |