| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: Large writable variables |
| Date: | 2018-10-17 21:51:06 |
| Message-ID: | 20181017215106.esosgw7qfnfavcdw@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-10-17 23:43:31 +0200, Peter Eisentraut wrote:
> On 17/10/2018 22:02, Andres Freund wrote:
> >> Your version with __builtin_types_compatible_p() doesn't work for
> >> casting between char * and const char *, so it wouldn't be very useful.
> > Huh, why wouldn't it work for char *? Seems to work fine for me?
>
> __builtin_types_compatible_p(const char *, char *) returns false (0) for me.
Right, that's why I added a const, inside the macro, to the type
specified in the unconstify argument. So typeof() yields a const char *,
and the return type is specified as char *, and adding a const in the
argument also yields a const char *.
I'd merged my version since, I don't feel particularly attached to it
though...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-10-17 22:05:15 | pg_stat_ssl additions |
| Previous Message | Peter Eisentraut | 2018-10-17 21:43:31 | Re: Large writable variables |