Re: pgsql: Add TAP tests for pg_verify_checksums

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add TAP tests for pg_verify_checksums
Date: 2018-10-16 22:09:00
Message-ID: 20181016220900.GA2331@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Oct 15, 2018 at 11:20:28AM -0400, Andrew Dunstan wrote:
> On 10/15/2018 11:05 AM, Tom Lane wrote:
>> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>>> We should fix this in PG11 rather than ship a broken utility. If
>>> everyone is happy, I can apply this.
>>
>> At this point I'd be happier if you waited till after 11.0 wraps...
>> there is no margin for error today.

If there is no urgency for this week, could you let me wrap this patch
then? I cannot do that this week, but the beginning of next week will
be fine per the current odds.

> OK. In that case should we note that the utility is broken on Windows?

Not sure if that's worth adding in the documentation, something in the
press release would be more adapted?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-10-16 22:47:55 Re: pgsql: Add TAP tests for pg_verify_checksums
Previous Message pgsql 2018-10-16 22:02:42 pgsql: Tag refs/tags/REL_11_0 was created

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-10-16 22:40:18 Re: Large writable variables
Previous Message Andres Freund 2018-10-16 20:59:06 Re: Large writable variables