| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Date: | 2018-10-14 01:59:02 |
| Message-ID: | 20181014015902.GI30064@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Oct 13, 2018 at 05:53:00PM -0400, Andrew Dunstan wrote:
> It occurred to me that a pretty simple fix could just be to blacklist
> everything that didn't start with a digit. The whitelist approach is
> probably preferable... depends how urgent we see this as.
Yeah, possibly, still that's not a correct long-term fix. So attached
is what I think we should do for HEAD and REL_11_STABLE with an approach
using a whitelist. I have added positive and negative tests on top of
the existing TAP tests, as suggested by Michael B, and I made the code
use relpath.h to make sure that we don't miss any fork types.
Any objections to this patch?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| checksum-whitelist-v2.patch | text/x-diff | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-10-14 02:03:28 | Re: pgsql: Add list of acknowledgments to release notes |
| Previous Message | Tom Lane | 2018-10-14 01:39:53 | pgsql: Doc: still further copy-editing for v11 release notes. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2018-10-14 02:08:49 | Re: fine tune v11 release notes |
| Previous Message | Tom Lane | 2018-10-14 01:45:33 | Re: fine tune v11 release notes |