Re: pgsql: Add TAP tests for pg_verify_checksums

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add TAP tests for pg_verify_checksums
Date: 2018-10-12 03:11:58
Message-ID: 20181012031158.GD30064@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Oct 11, 2018 at 07:41:18PM -0700, Andres Freund wrote:
> We only remove temp dirs on startup, and I'm pretty sure there at least
> not too long ago were a few error cases where we can leak temp files in
> individual sessions. And there's talk about allowing
> pg_verify_checksums when online. So this seems to be an angle that
> needs to be thought about...

Agreed. I am just working on a patch for v11- which uses a
whitelist-based method instead of what is present now. Reverting the
tests to put the buildfarm to green could be done, but that's not the
root of the problem.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-10-12 06:05:43 Re: pgsql: Add TAP tests for pg_verify_checksums
Previous Message Andres Freund 2018-10-12 02:41:18 Re: pgsql: Add TAP tests for pg_verify_checksums

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-10-12 03:29:28 Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel
Previous Message Michael Paquier 2018-10-12 02:49:01 Re: out-of-order XID insertion in KnownAssignedXids