| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Date: | 2018-10-12 02:41:18 |
| Message-ID: | 20181012024118.q3jwio7gf52nsrmm@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2018-10-12 11:07:58 +0900, Michael Paquier wrote:
> On Thu, Oct 11, 2018 at 06:53:19PM -0700, Andres Freund wrote:
> > Hm. Maybe I'm confused, but how is it correct to use a blacklisting
> > approach here? It's far from absurd to have files inside a tablespacs
> > when using temp_tablespace that aren't written through the buffer
> > manager. Like, uh, temp files, when using temp_tablespaces.
>
> pg_verify_checksums assumes that the cluster has been cleanly shut
> down so temp files are not an issue, no? However...
We only remove temp dirs on startup, and I'm pretty sure there at least
not too long ago were a few error cases where we can leak temp files in
individual sessions. And there's talk about allowing
pg_verify_checksums when online. So this seems to be an angle that
needs to be thought about...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-12 03:11:58 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Previous Message | Michael Paquier | 2018-10-12 02:07:58 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-12 02:49:01 | Re: out-of-order XID insertion in KnownAssignedXids |
| Previous Message | Michael Paquier | 2018-10-12 02:07:58 | Re: pgsql: Add TAP tests for pg_verify_checksums |