| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Subject: | Re: Refactor textToQualifiedNameList() |
| Date: | 2018-10-11 01:01:05 |
| Message-ID: | 20181011010105.GE2204@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 10, 2018 at 09:45:22AM -0300, Alvaro Herrera wrote:
> On 2018-Oct-10, Michael Paquier wrote:
>> On Tue, Oct 09, 2018 at 09:54:12AM -0300, Alvaro Herrera wrote:
>>> The committer of such a change will get a lot of flak for changing the
>>> #include requirements for code that calls that function, though.
>>
>> So the patch has been switched to rejected...
>
> I know -- I'm just disagreeing with that.
The point of moving stringToQualifiedNameList out of regproc.c to
varlena.c is actually a good one, if we don't add the extra palloc
overhead. Now I suspect that any change of header makes plugin
maintainers unhappy, and I can see this routine extensively used on
github, like pipelineDB or such.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-11 01:29:07 | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Previous Message | Bruce Momjian | 2018-10-10 23:57:20 | Re: Postgres 11 release notes |