| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-10-09 18:37:04 |
| Message-ID: | 20181009183704.dglhavr34dksce6a@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-10-09 14:32:29 -0400, Andrew Dunstan wrote:
>
>
> On 10/08/2018 09:55 PM, Tom Lane wrote:
> > Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> > > Rebased again. Patches that touch AC_CHECK_FUNCS are fun like that!
> > Yeah, I've been burnt by that too recently. It occurs to me we could make
> > that at least a little less painful if we formatted the macro with one
> > line per function name:
> >
> > AC_CHECK_FUNCS([
> > cbrt
> > clock_gettime
> > fdatasync
> > ...
> > wcstombs_l
> > ])
> >
> > You'd still get conflicts in configure itself, of course, but that
> > doesn't require manual work to resolve -- just re-run autoconf.
> >
> >
>
>
>
> By and large I think it's better not to submit patches with changes to
> configure, but to let the committer run autoconf.
> OTOH, this will probably confuse the heck out of the cfbot patch checker.
And make life harder for reviewers.
-1 on this one.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-10-09 18:50:15 | Re: pread() and pwrite() |
| Previous Message | Tom Lane | 2018-10-09 18:35:02 | Re: executor relation handling |