Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1
Date: 2018-10-06 06:00:38
Message-ID: 20181006060038.GA4835@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 05, 2018 at 11:27:59PM -0300, Alvaro Herrera wrote:
> Well, I think partially filling the struct is bad style. I'm going to
> be messing with that shortly anyway, when adding support for FKs
> pointing to partitioned tables; maybe just leave it as is for now and
> I'll see about that later.

Yes, I agree that we had better change that on HEAD as that's a trap
waiting ahead. I have let the comment as-is then.

> Please feel free if you have the time, thanks.

Okay, done and back-patched down to v11 where this was introduced.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-10-06 06:26:31 Re: partition tree inspection functions
Previous Message Edmund Horner 2018-10-06 05:20:37 Re: Calculate total_table_pages after set_base_rel_sizes()