Re: Function for listing archive_status directory

From: 'Christoph Moench-Tegeder' <cmt(at)burggraben(dot)net>
To: "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Function for listing archive_status directory
Date: 2018-10-05 11:06:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


## Iwata, Aya (iwata(dot)aya(at)jp(dot)fujitsu(dot)com):

> I think it is convenient to be able to check the archive_status
> directory contents information.
> I reviewed patch. It applies and passes regression test.

Great, thanks!

> All similar function are named pg_ls_***dir. It is clear these functions
> return directory contents information.
> If the new function intends to display the contents of the directory,
> pg_ls_***dir style might be better (e.g. pg_ls_archive_statusdir).
> But everyone know archive_status is a directory...
> If you want to follow the standard naming, then you may add the dir.

I conciously omitted the "_dir" suffix - I'm not a great fan of long
function names, and we want to inspect the contents of archive_status
to find out about the status of the archiving process. But then, my
main concern is the functionality, not the name, we can easily change
the name. Is there any other opinion pro/contra the name?

> Do you watch this thread?
> They are also discussing about generic pg_ls function.

I'm aware of that threat, and that Michael just commited "pg_ls_tmpdir()".
I'm not that sure about Laurenz' idea regarding monitoring all the
database directories (but it doesn't hurt anybody...). Anyway, the
archive_status directory is not coupled to any specific database or
tablespace, so there's not too much overlap.


Spare Space

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-10-05 11:28:54 Re: transction_timestamp() inside of procedures
Previous Message Etsuro Fujita 2018-10-05 10:15:41 Re: Problems with plan estimates in postgres_fdw