| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marco Slot <marco(at)citusdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Onder Kalaci <onder(at)citusdata(dot)com> |
| Subject: | Re: Segfault when creating partition with a primary key and sql_drop trigger exists |
| Date: | 2018-10-04 21:59:37 |
| Message-ID: | 20181004215937.orzx5asr6wn6rn2v@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Oct-03, Michael Paquier wrote:
> Okay. I have spent more time on this issue, and I have been able to
> integrate a test in the existing event_trigger.sql which is able to
> reproduce the reported failure. Attached is what I am finishing with.
>
> I still want to do more testing on it, and the day is ending here.
I looked at this, and I think that this particular crash you're fixing
is just a symptom of a larger problem in the event trigger alter table
handling -- I noticed while playing a bit with
src/test/modules/test_ddl_decoding (modify sql/alter_table.sql to create
a partitioned table with nullable columns and a partition, then alter
table to add a primary key).
I'm tied up in something else at the moment so can't spend more time on
it, but I hope to have time to give it a look over the weekend.
Thanks
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-10-04 22:04:49 | Re: Segfault when creating partition with a primary key and sql_drop trigger exists |
| Previous Message | Tom Lane | 2018-10-04 21:57:53 | Re: snprintf assert is broken by plpgsql #option dump |