| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Onder Kalaci <onder(at)citusdata(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Date: | 2018-10-04 07:59:23 |
| Message-ID: | 20181004075923.GA1256@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 03, 2018 at 12:09:54PM +1300, Thomas Munro wrote:
> It looks like you missed another case that needs tolerance for late
> signal delivery on Windows:
>
> +select pg_cancel_backend(pg_backend_pid());
>
> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.15263
Looking at 0001, why are the declarations needed in patch 0002 part of
0001 (see signalfuncs.h)? I think that something like instead the
attached is enough for this part. Daniel, could you confirm?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| signalfuncs-refactor.patch | text/x-diff | 13.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2018-10-04 08:06:06 | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Previous Message | Amit Langote | 2018-10-04 07:53:02 | Re: partition tree inspection functions |