| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Onder Kalaci <onder(at)citusdata(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Date: | 2018-10-04 08:06:06 |
| Message-ID: | 1E604809-E4DB-4FCE-B901-0E289D36C92B@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 4 Oct 2018, at 09:59, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Oct 03, 2018 at 12:09:54PM +1300, Thomas Munro wrote:
>> It looks like you missed another case that needs tolerance for late
>> signal delivery on Windows:
>>
>> +select pg_cancel_backend(pg_backend_pid());
>>
>> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.15263
>
> Looking at 0001, why are the declarations needed in patch 0002 part of
> 0001 (see signalfuncs.h)? I think that something like instead the
> attached is enough for this part. Daniel, could you confirm?
Yes, you are correct, the signalfuncs.h includes in 0001 are a rebase error
from when I renamed the file. They are not present in the v15 patch but got
introduced in v16 when I clearly wasn’t caffeinated enough to rebase.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Imai, Yoshikazu | 2018-10-04 08:11:11 | RE: speeding up planning with partitions |
| Previous Message | Michael Paquier | 2018-10-04 07:59:23 | Re: [HACKERS] Optional message to user when terminating/cancelling backend |