Re: pgsql: Build src/common files as a library with -fPIC.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Build src/common files as a library with -fPIC.
Date: 2018-09-28 18:56:48
Message-ID: 20180928185648.afdfgyw2wpagkved@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2018-09-28 18:28:30 +0000, Tom Lane wrote:
> Build src/common files as a library with -fPIC.
>
> Build a third version of libpgcommon.a, with -fPIC and -DFRONTEND,
> as commit ea53100d5 did for src/port. Use that in libpq to avoid
> symlinking+rebuilding source files retail.
>
> Also adjust ecpg to use the new src/port and src/common libraries.
>
> Arrange to install these libraries, too, to simplify out-of-tree
> builds of shared libraries that need any of these modules.
>
> Discussion: https://postgr.es/m/13022.1538003440@sss.pgh.pa.us
> Discussion: https://postgr.es/m/E1g5Y8r-0006vs-QA@gemulon.postgresql.org

I assume you noticed
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=woodlouse&dt=2018-09-28%2018%3A42%3A53
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2018-09-28%2018%3A30%3A25

Looks like Mkvcbuild.pm needs some tweaking, too.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-09-28 19:02:36 Re: pgsql: Build src/common files as a library with -fPIC.
Previous Message Tom Lane 2018-09-28 18:28:30 pgsql: Build src/common files as a library with -fPIC.