Re: master, static inline and #ifndef FRONTEND

Hi,

On 2018-09-10 09:50:15 -0700, Andres Freund wrote:
> On 2018-09-10 12:39:16 -0400, Tom Lane wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> > > In a recent commit [1] I added a static inline which castoroides
> > > dislikes: ...
> > > It's obviously trivial to fix this case with by adding an #ifndef
> > > FRONTEND. But as castoroides appears to be the only animal showing the
> > > problem - after subtracting the animals dead due to the C99 requirement
> > > - I wonder if we shouldn't just require "proper" static inline
> > > support. castoroides runs a 13yo OS, and newer compilers that do not
> > > have the problem are readily available.
> >
> > Given that we currently have *no* working Solaris buildfarm members,
> > I'm not prepared to tolerate "I can't be bothered to fix this",
> > which is what your argument boils down to.
>
> Uh, this seems unnecessarily dismissive. I wrote the above email minutes
> after noticing the issue ( which in turn was shortly after the issue
> occured), asking for feedback. Hardly "I can't be bothered to fix it"
> territory. But adding a lot of #ifndef FRONTENDs isn't entirely free
> either...

Fwi, I've pinged Dave about upgrading the compiler on that machine, and
he wrote:

On 2018-09-26 17:04:29 -0400, Dave Page wrote:
> Unfortunately, i think that whole machine is basically EOL now. It's
> already skipping OpenSSL for some builds, as being stuck on a very old
> version of the buildfarm client, as some of the modules used in newer
> versions just won't compile or work. I don't have any support contract, or
> access to newer versions of SunStudio, and the guys that used to package
> GCC for Solaris now charge to download their packages.

he has subsequently disabled building master on protosciurus and
casteroides.

Greetings,

Andres Freund