From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Remove absolete function TupleDescGetSlot(). |
Date: | 2018-09-27 18:42:49 |
Message-ID: | 20180927184249.6mta5k6fk6ul2gjq@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 2018-09-26 12:35:25 -0700, Andres Freund wrote:
> Hi,
>
> On 2018-09-26 12:41:38 +0900, Michael Paquier wrote:
> > On Tue, Sep 25, 2018 at 06:42:51PM -0700, Andres Freund wrote:
> > > My point is that FuncCallContext->slot isn't actually all that related
> > > to TupleDescGetSlot() and could be used entirely independently.
> >
> > That's fair. Why not just replacing the existing comment with something
> > like "slot can be used in your own context to store tuple values,
> > useful in the context of user-defined SRFs"? Just my 2c.
>
> I've tried to do search for users of FuncCallContext->slot and couldn't
> find anything. Therefore I'm more inclined to drop it too - just about
> all cases where it's useful seem to require a more extensive
> datastructure around anyway. Unless somebody protests I'm going to that
> in a few - if somebody later in the cycle signals a need for it, we can
> still revert that part.
Done so now.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2018-09-27 20:31:24 | pgsql: Remove extra usage of BoxPGetDatum() macro |
Previous Message | Andres Freund | 2018-09-27 18:42:30 | pgsql: Clean up in the wake of TupleDescGetSlot() removal / 10763358c3f |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-09-27 19:48:36 | Re: Let's stop with the retail rebuilds of src/port/ files already |
Previous Message | Mark Dilger | 2018-09-27 17:28:16 | Re: [HACKERS] [PATCH] kNN for SP-GiST |