Re: Problem while setting the fpw with SIGHUP

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, hlinnaka <hlinnaka(at)iki(dot)fi>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Problem while setting the fpw with SIGHUP
Date: 2018-09-27 12:51:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Sep 27, 2018 at 04:19:02PM +0530, Amit Kapila wrote:
> I think this is mostly fine, but it seems "if the instance just got
> out of recovery" doesn't fit well because it can happen anytime after
> recovery, this code gets called from checkpointer. I think we can
> slightly tweak it as below:
> "Perform this outside critical section so that the WAL insert
> initialization done by RecoveryInProgress() doesn't trigger an
> assertion failure."
> What do you say?

Fine for me.

>> Sure, feel free to if you have some room. I am fine to take care of it
>> as well, so that's up to you to decide.
> Okay, I will take care of it.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-09-27 13:00:49 Re: shared-memory based stats collector
Previous Message Tomas Vondra 2018-09-27 10:57:12 Re: [PATCH] Improve geometric types