| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, hlinnaka <hlinnaka(at)iki(dot)fi>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem while setting the fpw with SIGHUP |
| Date: | 2018-09-27 05:04:40 |
| Message-ID: | 20180927050440.GR1659@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 27, 2018 at 10:03:59AM +0530, Amit Kapila wrote:
> I think, in this case, it might be advisable to just fix the problem
> (a) which is what has been reported originally in the thread and
> AFAICS, the fix for that is clear as compared to the problem (b). If
> you agree, then we can discuss what is the best fix for the first
> problem (a).
Okay, thanks for the input. The fix for (a) would be in my opinion to
just move the call to RecoveryInProgress() out of the critical section,
then save the result into a variable, and use the variable within the
critical section to avoid the potential palloc() problems. What do you
think?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-09-27 05:10:59 | Re: Let's stop with the retail rebuilds of src/port/ files already |
| Previous Message | Andrew Gierth | 2018-09-27 04:58:48 | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |