Re: Segfault when creating partition with a primary key and sql_drop trigger exists

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, marco(at)citusdata(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, onder(at)citusdata(dot)com
Subject: Re: Segfault when creating partition with a primary key and sql_drop trigger exists
Date: 2018-09-26 03:33:24
Message-ID: 20180926033324.GH1659@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 25, 2018 at 01:39:59PM +0200, Dmitry Dolgov wrote:
> Shouldn't it be fixed by adding EventTriggerAlterTableStart? Judging from the
> following call of ATController, we can just pass NULL as parsetree.

Hmm. I don't think that this is correct as this data could always be
used to fetch a command tag, right? It seems to me instead that we
should pass down IndexStmt and handle things like the attached.
Thoughts?
--
Michael

Attachment Content-Type Size
event-partition-v1.patch text/x-diff 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-09-26 03:41:38 Re: pgsql: Remove absolete function TupleDescGetSlot().
Previous Message Andres Freund 2018-09-26 01:42:51 Re: pgsql: Remove absolete function TupleDescGetSlot().