| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: TupleTableSlot abstraction |
| Date: | 2018-09-25 23:45:09 |
| Message-ID: | 20180925234509.3hrrf6tmvy5tfith@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-09-04 18:35:34 +0530, Amit Khandekar wrote:
> Subject: [PATCH 05/14] Use tts_flags instead of previous bool members
>
> Pack the boolean members in TupleTableSlot into a 16 bit tts_flags.
> This reduces the size of TupleTableSlot since each bool member takes
> at least a byte on the platforms where bool is defined as a char.
>
> Ashutosh Bapat and Andres Freund
> +
> +/* true = slot is empty */
> +#define TTS_ISEMPTY (1 << 1)
> +#define IS_TTS_EMPTY(slot) ((slot)->tts_flags & TTS_ISEMPTY)
> +#define SET_TTS_EMPTY(slot) ((slot)->tts_flags |= TTS_ISEMPTY)
> +#define RESET_TTS_EMPTY(slot) ((slot)->tts_flags &= ~TTS_ISEMPTY)
The flag stuff is the right way, but I'm a bit dubious about the
accessor functions. I can see open-coding the accesses, using the
macros, or potentially going towards using bitfields.
Any comments?
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-09-26 00:04:14 | Re: pgsql: Remove absolete function TupleDescGetSlot(). |
| Previous Message | Andres Freund | 2018-09-25 23:40:26 | Re: transction_timestamp() inside of procedures |