Re: [patch] Bug in pg_dump/pg_restore using --no-publication

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [patch] Bug in pg_dump/pg_restore using --no-publication
Date: 2018-09-25 02:08:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Sep 21, 2018 at 05:44:02PM +0200, Gilles Darold wrote:
> Attached is a patch that fixes a bug in pg_dump since 10.0 and
> reproducible in master. When using option --no-publication : ALTER
> PUBLICATION orders are still present in the dump.

Thanks for the report, the patch, and the test case, Gilles!

> pg_restore --no-publication test.dump -l test.dump| grep PUBLICATION
> 2230; 6106 16389 PUBLICATION TABLE public p1 t1
> 2231; 6106 16392 PUBLICATION TABLE public p_insert_only t1

This command does not actually work ;)

> Should I add it to current commitfest ?

No need to. I have committed your patch down to v10 after making sure
that we are not missing any other spots, and testing each branch

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-09-25 02:09:08 DNS SRV support for LDAP authentication
Previous Message Tsunakawa, Takayuki 2018-09-25 02:03:51 RE: Changing the setting of wal_sender_timeout per standby