| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role |
| Date: | 2018-09-25 00:58:07 |
| Message-ID: | 20180925005807.GB1354@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 24, 2018 at 12:02:35PM -0400, Tom Lane wrote:
> For v10 and up, the method used in 53b79ab4 is overcomplicated: you only
> need to add a delta script not a new base script. (If you had to
> back-patch before v10, it might be best to add a new base script in all
> the branches just to keep the patches consistent; but IIUC this issue only
> arises in v10 and up.) I'd consider following, eg, 7f563c09f as a
> prototype instead.
Of course, thanks. Sorry for the incorrect reference pointing to a
commit of REL9_6_STABLE. As the patch only needs to be applied down to
v10, there is no need to do anything more complicated than what Hari has
proposed. So, committed after a bit of comment and format tweaks.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-09-25 01:02:09 | Re: Proposal for Signal Detection Refactoring |
| Previous Message | Andrew Gierth | 2018-09-25 00:51:28 | Re: Implementing SQL ASSERTION |