| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE |
| Date: | 2018-09-20 22:46:24 |
| Message-ID: | 20180920224624.toqzjvgn6ivmrwud@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-09-20 18:38:36 -0400, Tom Lane wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> > . o O ( hmm, we now have variadic macros )
>
> hmmm ... but even with variadic, C's macro facility is so weak that
> I'm not sure we can reimplement these with it. What would the
> expansion look like?
There's a dirty hack to count arguments in vararg macros:
https://groups.google.com/d/msg/comp.std.c/d-6Mj5Lko_s/5fW1bP6T3RIJ
Afaict that ought to be enough to implement something like the current
macros? Whether that's too ugly or not, I don't know.
> It constantly annoys me that C's so weak here.
Yea. Weak and fragile, both.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-20 23:03:16 | Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE |
| Previous Message | Tom Lane | 2018-09-20 22:38:36 | Re: Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE |